-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pin event-tracking for pymongo 4.4.0 support #433
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
I think this is the right solution until openedx/edx-platform#34675 lands, does that make sense to you @mumarkhan999 ? @feanil is looking at the issues with commitlint on this repo currently. |
Commitlint issue should be fixed if you rebase off the latest master branch. |
415754f
to
208ad92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion for extra context on when this can be unpinned.
208ad92
to
c750492
Compare
@feanil thanks, it's ready for review now |
# Cause: https://github.com/openedx/event-tracking/pull/290 | ||
# event-tracking 2.4.1 upgrades to pymongo 4.4.0 which is not supported on edx-platform. | ||
# We will pin event-tracking to do not break existing installations | ||
# See |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# See | |
# This can be unpinned once https://github.com/openedx/edx-platform/issues/34586 has been resolved and edx-platform is running with pymong>= 4.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you missed the link.
c750492
to
11eff60
Compare
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
Pins event-tracking to a version before installing pymongo 4.4.0 which is not supported on edx-platform.
See openedx/tutor-contrib-aspects#891, openedx/event-routing-backends#436, openedx/completion#305 for more information.
Merge checklist: